Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates Releases page to mention v1.23.3 #31505

Merged
merged 1 commit into from
Jan 26, 2022
Merged

Updates Releases page to mention v1.23.3 #31505

merged 1 commit into from
Jan 26, 2022
+7 −3

Conversation

Babapool
Copy link
Member

Fixes #31501

This PR :

  • Updates the Release page to the mention of the Out of Band v1.23.3 release, scheduled to be released today (i.e. 2022-01-25)

Pages updated are: https://github.com/kubernetes/website/blob/main/data/releases/schedule.yaml

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/release-eng Issues or PRs related to the Release Engineering subproject labels Jan 25, 2022
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/release Categorizes an issue or PR as relevant to SIG Release. labels Jan 25, 2022
@Babapool
Copy link
Member Author

Babapool commented Jan 25, 2022 •
edited
Loading

I have also added the note attribute/component to be v1.23.3 based on seeing other versions which have included it. If it is not necessary to include it I am happy to remove it by pushing another commit. Thanks.

sftim
sftim reviewed Jan 25, 2022
View reviewed changes
data/releases/schedule.yaml
Comment on lines +5 to +6
cherryPickDeadline: 2022-02-11
targetDate: 2022-02-16
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these dates correct?

Copy link
Member Author

@Babapool Babapool Jan 25, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sftim : I saw these dates from here: https://kubernetes.io/releases/patch-releases/#upcoming-monthly-releases , and the January release date corresponded to this schedule given so that is why I used the dates used above.

data/releases/schedule.yaml
- release: 1.23.3
cherryPickDeadLine: 2022-01-24
targetDate: 2022-01-25
note: "Out-of-Bound Release https://groups.google.com/u/2/a/kubernetes.io/g/dev/c/Xl1sm-CItaY"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @Babapool

@netlify
Copy link

netlify bot commented Jan 25, 2022

✔️ Deploy Preview for kubernetes-io-main-staging ready!

🔨 Explore the source changes: 345ff4f

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/61f016e360b71200088e0a46

😎 Browse the preview: https://deploy-preview-31505--kubernetes-io-main-staging.netlify.app

@reylejano
Copy link
Member

reylejano commented Jan 25, 2022 •
edited
Loading

The 1.23.3 dates are correct
source: #31494
@puerco can you confirm the 1.23.4 dates are correct

@sftim
Copy link
Contributor

sftim commented Jan 26, 2022

I'm going to approve this because after this goes out, the information on the site is still wrong, but it's less wrong than before.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 26, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 27779fab2404fc11fdb635cc8c871d2c8f026018

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 26, 2022
@k8s-ci-robot k8s-ci-robot merged commit f7b9625 into kubernetes:main Jan 26, 2022
@Babapool
Copy link
Member Author

Hi @sftim, If the v1.23.4 dates are not correct, I will correct them by opening another PR. Thanks.

@Babapool Babapool mentioned this pull request Apr 20, 2022
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@onlydole onlydole Awaiting requested review from onlydole

Assignees

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v1.23.3 missing from release details
4 participants
@Babapool @reylejano @sftim @k8s-ci-robot